unable to edit feedback

by Martin H.  

Hi,

I didn't have this problem in Moodle 2.9 but it is a problem in Moodle 3.1 now.

I have some assignments that students can attempt up to 3 times until they pass. So  a pass mark of 60 (out of 100) is set for the assignment.

The problem is as long as a marker marks a submitted assignment, a new attempt gets created for the student.

These are the steps to replicate the issue:

Assignment settings:

• "Attempts reopened" set to "Automatically until pass"
• "maximum attempts" set to 3
• "Grade to pass" set to 60

Steps:

1. A student submits a file (status automatically changes to: Submitted for grading)
   
2. A marker writes some feedback and marks the assignment as 40 (status automatically changes to: Reopened)
3. The marker then decides to change their feedback. So:
   1. The marker goes back to the grading screen for the student
   2. The marker clicks on the "View a different attempt" button and select student's first attempt.
   3. The marker see the comment they had written earlier. So they edit the comment and click on "save changes" button.

What happens is:

 - the feedback is saved for the second attempt; An attempt that has never been made!