hmm,
it seems if I comment out these lines relating to blind marking, everything works again
if ($blindmarking) {
$info->username = get_string('participant', 'assign') . ' ' . $uniqueidforuser;
// $userfrom->firstname = get_string('participant', 'assign');
// $userfrom->lastname = $uniqueidforuser;
// $userfrom->email = $CFG->noreplyaddress;
} else {
$info->username = fullname($userfrom, true);
}
but I think those are the ones put in to prevent the issue of https://tracker.moodle.org/browse/MDL-38113
Now for me thats not really a problem, because our tutors don't use the grader notification anyway, but I'd still like to know what's happened and how to fix it in case the issue in my original post applies to anyone else.
But is this only an issue because I've backported the 2.6 assign module - in which case is it an issue on 2.6, but the fix works on 2.5 - or is it only on 2.5 with the backported module and I've missed some kind of clash somewhere when doing the backport ?
I guess I have some more testing to do to see if I can come up with those answers!
Richard